mmc: renesas_sdhi: simplify reset routine a little
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 10 Nov 2020 14:20:58 +0000 (15:20 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 16 Nov 2020 11:48:24 +0000 (12:48 +0100)
The 'reset' pointer is only populated for Gen2+. So, we don't need to
check for that flag inside the routine.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/20201110142058.36393-5-wsa+renesas@sang-engineering.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/renesas_sdhi_core.c

index 4a1ed5b..1fabf8c 100644 (file)
@@ -552,6 +552,7 @@ static int renesas_sdhi_prepare_hs400_tuning(struct mmc_host *mmc, struct mmc_io
        return 0;
 }
 
+/* only populated for TMIO_MMC_MIN_RCAR2 */
 static void renesas_sdhi_reset(struct tmio_mmc_host *host)
 {
        struct renesas_sdhi *priv = host_to_priv(host);
@@ -569,9 +570,7 @@ static void renesas_sdhi_reset(struct tmio_mmc_host *host)
                               sd_scc_read32(host, priv, SH_MOBILE_SDHI_SCC_RVSCNTL));
        }
 
-       if (host->pdata->flags & TMIO_MMC_MIN_RCAR2)
-               sd_ctrl_write32_as_16_and_16(host, CTL_IRQ_MASK,
-                                            TMIO_MASK_INIT_RCAR2);
+       sd_ctrl_write32_as_16_and_16(host, CTL_IRQ_MASK, TMIO_MASK_INIT_RCAR2);
 }
 
 #define SH_MOBILE_SDHI_MIN_TAP_ROW 3