PCI: xgene-msi: Remove redundant dev_err() call in xgene_msi_probe()
authorErKun Yang <yangerkun@huawei.com>
Thu, 8 Apr 2021 13:27:51 +0000 (21:27 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Thu, 5 Aug 2021 11:05:06 +0000 (12:05 +0100)
devm_ioremap_resource() internally calls __devm_ioremap_resource() which
is where error checking and handling is actually taking place. i

Therefore, the dev_err() call in xgene_msi_probe() is redundant.

Remove it.

Link: https://lore.kernel.org/r/20210408132751.1198171-1-yangerkun@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ErKun Yang <yangerkun@huawei.com>
[lorenzo.pieralisi@arm.com: commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Krzysztof WilczyƄski <kw@linux.com>
drivers/pci/controller/pci-xgene-msi.c

index 1c34c89..369b50f 100644 (file)
@@ -451,7 +451,6 @@ static int xgene_msi_probe(struct platform_device *pdev)
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(xgene_msi->msi_regs)) {
-               dev_err(&pdev->dev, "no reg space\n");
                rc = PTR_ERR(xgene_msi->msi_regs);
                goto error;
        }