dm crypt: fix GFP flags passed to skcipher_request_alloc()
authorMikulas Patocka <mpatocka@redhat.com>
Thu, 2 Jan 2020 13:23:32 +0000 (08:23 -0500)
committerMike Snitzer <snitzer@redhat.com>
Tue, 7 Jan 2020 17:07:32 +0000 (12:07 -0500)
GFP_KERNEL is not supposed to be or'd with GFP_NOFS (the result is
equivalent to GFP_KERNEL). Also, we use GFP_NOIO instead of GFP_NOFS
because we don't want any I/O being submitted in the direct reclaim
path.

Fixes: 39d13a1ac41d ("dm crypt: reuse eboiv skcipher for IV generation")
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-crypt.c

index eb9782f..9a18388 100644 (file)
@@ -717,7 +717,7 @@ static int crypt_iv_eboiv_gen(struct crypt_config *cc, u8 *iv,
        struct crypto_wait wait;
        int err;
 
-       req = skcipher_request_alloc(any_tfm(cc), GFP_KERNEL | GFP_NOFS);
+       req = skcipher_request_alloc(any_tfm(cc), GFP_NOIO);
        if (!req)
                return -ENOMEM;