vdpa/mlx5: Fix possible uninitialized return value
authorEli Cohen <elic@nvidia.com>
Thu, 11 Aug 2022 13:40:10 +0000 (16:40 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 11 Aug 2022 14:00:36 +0000 (10:00 -0400)
Initialize err local variable to return -EAGAIN if the asid cannot be
found thus avoiding returning uninitialized value.

Fixes: 8fcd20c30704 ("vdpa/mlx5: Support different address spaces for control and data")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eli Cohen <elic@nvidia.com>
Message-Id: <20220811134010.952291-1-elic@nvidia.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/vdpa/mlx5/net/mlx5_vnet.c

index 289cf91..ed100a3 100644 (file)
@@ -2659,7 +2659,7 @@ static int mlx5_vdpa_set_map(struct vdpa_device *vdev, unsigned int asid,
 {
        struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);
        struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
-       int err;
+       int err = -EINVAL;
 
        down_write(&ndev->reslock);
        if (mvdev->group2asid[MLX5_VDPA_DATAVQ_GROUP] == asid) {