can: softing: Remove redundant variable ptr
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Tue, 27 Apr 2021 10:52:47 +0000 (18:52 +0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 27 May 2021 07:42:22 +0000 (09:42 +0200)
The value stored to ptr in the calculations this patch removes is not
used, so the calculation and the assignment can be removed.

Cleans up the following clang-analyzer warning:

drivers/net/can/softing/softing_main.c:279:3: warning: Value stored to
'ptr' is never read [clang-analyzer-deadcode.DeadStores].

drivers/net/can/softing/softing_main.c:242:3: warning: Value stored to
'ptr' is never read [clang-analyzer-deadcode.DeadStores].

Link: https://lore.kernel.org/r/1619520767-80948-1-git-send-email-jiapeng.chong@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/softing/softing_main.c

index c44f341..cfc1325 100644 (file)
@@ -239,7 +239,6 @@ static int softing_handle_1(struct softing *card)
                                DPRAM_INFO_BUSSTATE2 : DPRAM_INFO_BUSSTATE]);
                /* timestamp */
                tmp_u32 = le32_to_cpup((void *)ptr);
-               ptr += 4;
                ktime = softing_raw2ktime(card, tmp_u32);
 
                ++netdev->stats.rx_errors;
@@ -276,7 +275,6 @@ static int softing_handle_1(struct softing *card)
                ktime = softing_raw2ktime(card, tmp_u32);
                if (!(msg.can_id & CAN_RTR_FLAG))
                        memcpy(&msg.data[0], ptr, 8);
-               ptr += 8;
                /* update socket */
                if (cmd & CMD_ACK) {
                        /* acknowledge, was tx msg */