btrfs: remove unnecessary btrfs_i_size_write(0) calls
authorOmar Sandoval <osandov@fb.com>
Thu, 10 Mar 2022 01:31:35 +0000 (17:31 -0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 16 May 2022 15:03:06 +0000 (17:03 +0200)
btrfs_new_inode() always returns an inode with i_size and disk_i_size
set to 0 (via inode_init_always() and btrfs_alloc_inode(),
respectively). Remove the unnecessary calls to btrfs_i_size_write() in
btrfs_mkdir() and btrfs_create_subvol_root().

Reviewed-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode.c

index 46a82fb..b5059b1 100644 (file)
@@ -6601,7 +6601,6 @@ static int btrfs_mkdir(struct user_namespace *mnt_userns, struct inode *dir,
        if (err)
                goto out_fail;
 
-       btrfs_i_size_write(BTRFS_I(inode), 0);
        err = btrfs_update_inode(trans, root, BTRFS_I(inode));
        if (err)
                goto out_fail;
@@ -8780,7 +8779,6 @@ int btrfs_create_subvol_root(struct btrfs_trans_handle *trans,
        inode->i_fop = &btrfs_dir_file_operations;
 
        set_nlink(inode, 1);
-       btrfs_i_size_write(BTRFS_I(inode), 0);
        unlock_new_inode(inode);
 
        err = btrfs_subvol_inherit_props(trans, new_root, parent_root);