powercap/drivers/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols
authorDaniel Lezcano <daniel.lezcano@linaro.org>
Wed, 30 Dec 2020 15:37:44 +0000 (16:37 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 30 Dec 2020 17:47:33 +0000 (18:47 +0100)
32-bit architectures do not support u64 divisions, so the macro
DIV_ROUND_CLOSEST is not adequate as the compiler will replace the
call to an unexisting function for the platform, leading to
unresolved references to symbols.

Fix this by using the compatible macros:

DIV64_U64_ROUND_CLOSEST and DIV_ROUND_CLOSEST_ULL.

Fixes: a20d0ef97abf ("powercap/drivers/dtpm: Add API for dynamic thermal power management")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/powercap/dtpm.c

index 5b6857e..0abcc43 100644 (file)
@@ -99,8 +99,8 @@ static void __dtpm_rebalance_weight(struct dtpm *dtpm)
                pr_debug("Setting weight '%d' for '%s'\n",
                         child->weight, child->zone.name);
 
-               child->weight = DIV_ROUND_CLOSEST(child->power_max * 1024,
-                                                 dtpm->power_max);
+               child->weight = DIV64_U64_ROUND_CLOSEST(
+                       child->power_max * 1024, dtpm->power_max);
 
                __dtpm_rebalance_weight(child);
        }
@@ -272,7 +272,7 @@ static int __set_power_limit_uw(struct dtpm *dtpm, int cid, u64 power_limit)
                        } else if (power_limit == dtpm->power_min) {
                                power = child->power_min;
                        } else {
-                               power = DIV_ROUND_CLOSEST(
+                               power = DIV_ROUND_CLOSEST_ULL(
                                        power_limit * child->weight, 1024);
                        }