net: cxbg4: Remove pointless in_interrupt() check
authorThomas Gleixner <tglx@linutronix.de>
Tue, 29 Sep 2020 20:25:16 +0000 (22:25 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 29 Sep 2020 21:02:54 +0000 (14:02 -0700)
t4_sge_stop() is only ever called from task context and the in_interrupt()
check is presumably a leftover from copying t3_sge_stop().

Aside of in_interrupt() being deprecated because it's not providing what it
claims to provide, this check would paper over illegitimate callers.

The functions invoked from t4_sge_stop() contain already warnings to catch
invocations from invalid contexts.

Remove it.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/sge.c

index 2b942b4..54e22f1 100644 (file)
@@ -4872,9 +4872,6 @@ void t4_sge_stop(struct adapter *adap)
        int i;
        struct sge *s = &adap->sge;
 
-       if (in_interrupt())  /* actions below require waiting */
-               return;
-
        if (s->rx_timer.function)
                del_timer_sync(&s->rx_timer);
        if (s->tx_timer.function)