configfs: simplify the configfs_dirent_is_ready
authorChristoph Hellwig <hch@lst.de>
Wed, 25 Aug 2021 05:43:55 +0000 (07:43 +0200)
committerChristoph Hellwig <hch@lst.de>
Wed, 25 Aug 2021 05:43:55 +0000 (07:43 +0200)
Return the error directly instead of using a goto.

Signed-off-by: Christoph Hellwig <hch@lst.de>
fs/configfs/dir.c

index cf08bbd..5d58569 100644 (file)
@@ -467,9 +467,8 @@ static struct dentry * configfs_lookup(struct inode *dir,
         * not complete their initialization, since the dentries of the
         * attributes won't be instantiated.
         */
-       err = -ENOENT;
        if (!configfs_dirent_is_ready(parent_sd))
-               goto out;
+               return ERR_PTR(-ENOENT);
 
        list_for_each_entry(sd, &parent_sd->s_children, s_sibling) {
                if (sd->s_type & CONFIGFS_NOT_PINNED) {
@@ -493,7 +492,6 @@ static struct dentry * configfs_lookup(struct inode *dir,
                return NULL;
        }
 
-out:
        return ERR_PTR(err);
 }