media: atomisp: add -dDEBUG when building this driver

This driver still has lots of issues. Let's enable debug
there inconditionally, as we need more information in order
to address the pending issues.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/staging/media/atomisp/Makefile b/drivers/staging/media/atomisp/Makefile
index d166b5f..c032444 100644 (file)
--- a/drivers/staging/media/atomisp/Makefile
+++ b/drivers/staging/media/atomisp/Makefile
@@ -5,6 +5,9 @@ obj-$(CONFIG_INTEL_ATOMISP) += i2c/
 obj-$(CONFIG_INTEL_ATOMISP) += platform/
 obj-$(CONFIG_VIDEO_ATOMISP) += atomisp.o
 
+# While on staging, keep debug enabled
+DEFINES += -DDEBUG
+
 atomisp = $(srctree)/drivers/staging/media/atomisp/
 
 # SPDX-License-Identifier: GPL-2.0

diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
index 2b855e7..667d6f7 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
@@ -785,6 +785,7 @@ static int atomisp_open(struct file *file)
        asd->subdev.devnode = vdev;
        /* Deferred firmware loading case. */
        if (isp->css_env.isp_css_fw.bytes == 0) {
+               dev_err(isp->dev, "Deferred firmware load.\n");
                isp->firmware = atomisp_load_firmware(isp);
                if (!isp->firmware) {
                        dev_err(isp->dev, "Failed to load ISP firmware.\n");