perf script: Simplify bool conversion
authorYang Li <yang.lee@linux.alibaba.com>
Mon, 8 Feb 2021 08:45:36 +0000 (16:45 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 9 Feb 2021 17:58:56 +0000 (14:58 -0300)
  Fix the following coccicheck warning:
  ./tools/perf/builtin-script.c:2789:36-41: WARNING: conversion to bool
  not needed here
  ./tools/perf/builtin-script.c:3237:48-53: WARNING: conversion to bool
  not needed here

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Andrii Nakryiko <andrii@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: KP Singh <kpsingh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Martin KaFai Lau <kafai@fb.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <songliubraving@fb.com>
Cc: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/r/1612773936-98691-1-git-send-email-yang.lee@linux.alibaba.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-script.c

index 1ff7264..aef119b 100644 (file)
@@ -2795,7 +2795,7 @@ parse:
                                break;
                }
                if (i == imax && strcmp(tok, "flags") == 0) {
-                       print_flags = change == REMOVE ? false : true;
+                       print_flags = change != REMOVE;
                        continue;
                }
                if (i == imax) {
@@ -3243,7 +3243,7 @@ static char *get_script_path(const char *script_root, const char *suffix)
 
 static bool is_top_script(const char *script_path)
 {
-       return ends_with(script_path, "top") == NULL ? false : true;
+       return ends_with(script_path, "top") != NULL;
 }
 
 static int has_required_arg(char *script_path)