drm/ttm: Fix address passed to dma_mapping_error() in ttm_pool_map()
authorJeremy Cline <jcline@redhat.com>
Mon, 11 Jan 2021 16:40:33 +0000 (11:40 -0500)
committerChristian König <christian.koenig@amd.com>
Mon, 11 Jan 2021 20:18:27 +0000 (21:18 +0100)
check_unmap() is producing a warning about a missing map error check.
The return value from dma_map_page() should be checked for an error, not
the caller-provided dma_addr.

Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3")
Signed-off-by: Jeremy Cline <jcline@redhat.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/413432/
Signed-off-by: Christian König <christian.koenig@amd.com>
drivers/gpu/drm/ttm/ttm_pool.c

index a00b7ab..255c457 100644 (file)
@@ -190,7 +190,7 @@ static int ttm_pool_map(struct ttm_pool *pool, unsigned int order,
                size_t size = (1ULL << order) * PAGE_SIZE;
 
                addr = dma_map_page(pool->dev, p, 0, size, DMA_BIDIRECTIONAL);
-               if (dma_mapping_error(pool->dev, **dma_addr))
+               if (dma_mapping_error(pool->dev, addr))
                        return -EFAULT;
        }