libnvdimm/dimm: Simplify nvdimm_remove()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 12 Feb 2021 17:10:42 +0000 (18:10 +0100)
committerDan Williams <dan.j.williams@intel.com>
Wed, 17 Feb 2021 03:34:57 +0000 (19:34 -0800)
nvdimm_remove is only ever called after nvdimm_probe() returned
successfully. In this case driver data is always set to a non-NULL value
so the check for driver data being NULL can go away as it's always false.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210212171043.2136580-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/dimm.c

index 7d4ddc4..94be3ae 100644 (file)
@@ -117,9 +117,6 @@ static int nvdimm_remove(struct device *dev)
 {
        struct nvdimm_drvdata *ndd = dev_get_drvdata(dev);
 
-       if (!ndd)
-               return 0;
-
        nvdimm_bus_lock(dev);
        dev_set_drvdata(dev, NULL);
        nvdimm_bus_unlock(dev);