thunderbolt: Use kmemdup instead of kzalloc and memcpy
authorTian Tao <tiantao6@hisilicon.com>
Wed, 23 Dec 2020 01:26:33 +0000 (09:26 +0800)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Mon, 28 Dec 2020 09:41:53 +0000 (12:41 +0300)
Fixes coccicheck warning:
drivers/thunderbolt/dma_test.c:302:13-20: WARNING opportunity for kmemdup.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/thunderbolt/dma_test.c

index f924423..955f980 100644 (file)
@@ -299,14 +299,12 @@ static int dma_test_submit_tx(struct dma_test *dt, size_t npackets)
                tf->frame.size = 0; /* means 4096 */
                tf->dma_test = dt;
 
-               tf->data = kzalloc(DMA_TEST_FRAME_SIZE, GFP_KERNEL);
+               tf->data = kmemdup(dma_test_pattern, DMA_TEST_FRAME_SIZE, GFP_KERNEL);
                if (!tf->data) {
                        kfree(tf);
                        return -ENOMEM;
                }
 
-               memcpy(tf->data, dma_test_pattern, DMA_TEST_FRAME_SIZE);
-
                dma_addr = dma_map_single(dma_dev, tf->data, DMA_TEST_FRAME_SIZE,
                                          DMA_TO_DEVICE);
                if (dma_mapping_error(dma_dev, dma_addr)) {