clocksource/drivers/sp804: Cleanup clk_get_sys()
authorKefeng Wang <wangkefeng.wang@huawei.com>
Fri, 18 Sep 2020 13:22:29 +0000 (21:22 +0800)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 24 Sep 2020 08:51:04 +0000 (10:51 +0200)
Move the clk_get_sys() part into sp804_get_clock_rate(), cleanup the same
code.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20200918132237.3552-2-thunder.leizhen@huawei.com
drivers/clocksource/timer-sp804.c

index 5cd0abf..bec2d37 100644 (file)
 
 #include "timer-sp.h"
 
-static long __init sp804_get_clock_rate(struct clk *clk)
+static long __init sp804_get_clock_rate(struct clk *clk, const char *name)
 {
        long rate;
        int err;
 
+       if (!clk)
+               clk = clk_get_sys("sp804", name);
+       if (IS_ERR(clk)) {
+               pr_err("sp804: %s clock not found: %ld\n", name, PTR_ERR(clk));
+               return PTR_ERR(clk);
+       }
+
        err = clk_prepare(clk);
        if (err) {
                pr_err("sp804: clock failed to prepare: %d\n", err);
@@ -72,16 +79,7 @@ int  __init __sp804_clocksource_and_sched_clock_init(void __iomem *base,
 {
        long rate;
 
-       if (!clk) {
-               clk = clk_get_sys("sp804", name);
-               if (IS_ERR(clk)) {
-                       pr_err("sp804: clock not found: %d\n",
-                              (int)PTR_ERR(clk));
-                       return PTR_ERR(clk);
-               }
-       }
-
-       rate = sp804_get_clock_rate(clk);
+       rate = sp804_get_clock_rate(clk, name);
        if (rate < 0)
                return -EINVAL;
 
@@ -173,15 +171,7 @@ int __init __sp804_clockevents_init(void __iomem *base, unsigned int irq, struct
        struct clock_event_device *evt = &sp804_clockevent;
        long rate;
 
-       if (!clk)
-               clk = clk_get_sys("sp804", name);
-       if (IS_ERR(clk)) {
-               pr_err("sp804: %s clock not found: %d\n", name,
-                       (int)PTR_ERR(clk));
-               return PTR_ERR(clk);
-       }
-
-       rate = sp804_get_clock_rate(clk);
+       rate = sp804_get_clock_rate(clk, name);
        if (rate < 0)
                return -EINVAL;