ubifs: Fix type of sup->hash_algo
authorBen Dooks (Codethink) <ben.dooks@codethink.co.uk>
Wed, 16 Oct 2019 10:15:03 +0000 (11:15 +0100)
committerRichard Weinberger <richard@nod.at>
Sun, 17 Nov 2019 21:22:53 +0000 (22:22 +0100)
The sup->hash_algo is a __le16, and whilst 0xffff is
the same in __le16 and u16, it would be better to use
cpu_to_le16() anyway (which should deal with constants)
and silence the following sparse warning:

fs/ubifs/sb.c:187:32: warning: incorrect type in assignment (different base types)
fs/ubifs/sb.c:187:32:    expected restricted __le16 [usertype] hash_algo
fs/ubifs/sb.c:187:32:    got int

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/ubifs/sb.c

index a551eb3..2b7c04b 100644 (file)
@@ -184,7 +184,7 @@ static int create_default_filesystem(struct ubifs_info *c)
                if (err)
                        goto out;
        } else {
-               sup->hash_algo = 0xffff;
+               sup->hash_algo = cpu_to_le16(0xffff);
        }
 
        sup->ch.node_type  = UBIFS_SB_NODE;