mmc: dw_mmc: remove the unnecessary IS_ERR() checking for ciu/biu clock
authorJaehoon Chung <jh80.chung@samsung.com>
Fri, 15 Jul 2016 01:54:08 +0000 (10:54 +0900)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 26 Sep 2016 19:31:18 +0000 (21:31 +0200)
If ciu/biu clock are NULL, clk_disable_unprepare should be just
returned. In clk_disable_unprepare(), already checked whether clk is
error or NULL.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/dw_mmc.c

index cea26ab..1a1e1e1 100644 (file)
@@ -3151,12 +3151,10 @@ err_dmaunmap:
                host->dma_ops->exit(host);
 
 err_clk_ciu:
-       if (!IS_ERR(host->ciu_clk))
-               clk_disable_unprepare(host->ciu_clk);
+       clk_disable_unprepare(host->ciu_clk);
 
 err_clk_biu:
-       if (!IS_ERR(host->biu_clk))
-               clk_disable_unprepare(host->biu_clk);
+       clk_disable_unprepare(host->biu_clk);
 
        return ret;
 }
@@ -3182,11 +3180,8 @@ void dw_mci_remove(struct dw_mci *host)
        if (host->use_dma && host->dma_ops->exit)
                host->dma_ops->exit(host);
 
-       if (!IS_ERR(host->ciu_clk))
-               clk_disable_unprepare(host->ciu_clk);
-
-       if (!IS_ERR(host->biu_clk))
-               clk_disable_unprepare(host->biu_clk);
+       clk_disable_unprepare(host->ciu_clk);
+       clk_disable_unprepare(host->biu_clk);
 }
 EXPORT_SYMBOL(dw_mci_remove);