PCI: cpcihp: Declare cpci_debug in header file
authorKrzysztof Wilczyński <kw@linux.com>
Thu, 1 Jul 2021 18:43:06 +0000 (18:43 +0000)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 1 Jul 2021 20:32:45 +0000 (15:32 -0500)
cpci_debug is declared as a global variable in cpci_hotplug_core.c and used
in cpci_hotplug_pci.c via an "extern".  Add an extern declaration in the
header file.

Resolves the following sparse warning:

  drivers/pci/hotplug/cpci_hotplug_core.c:47:5: warning: symbol 'cpci_debug' was not declared. Should it be static?

Link: https://lore.kernel.org/r/20210701184306.1492003-1-kw@linux.com
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/hotplug/cpci_hotplug.h
drivers/pci/hotplug/cpci_hotplug_pci.c

index f33ff2b..3fdd1b9 100644 (file)
@@ -75,6 +75,9 @@ int cpci_hp_unregister_bus(struct pci_bus *bus);
 int cpci_hp_start(void);
 int cpci_hp_stop(void);
 
+/* Global variables */
+extern int cpci_debug;
+
 /*
  * Internal function prototypes, these functions should not be used by
  * board/chassis drivers.
index 2c16adb..6c48066 100644 (file)
@@ -19,8 +19,6 @@
 
 #define MY_NAME        "cpci_hotplug"
 
-extern int cpci_debug;
-
 #define dbg(format, arg...)                                    \
        do {                                                    \
                if (cpci_debug)                                 \