perf tests dlfilter: Free desc and long_desc in check_filter_desc
authorRiccardo Mancini <rickyman7@gmail.com>
Fri, 20 Aug 2021 11:31:29 +0000 (13:31 +0200)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 20 Aug 2021 14:16:27 +0000 (11:16 -0300)
In dlfilter-test.c, check_filter_desc() calls get_filter_desc() which
allocates 'desc' and 'long_desc'.  However, these variables are never
deallocated.

This patch adds the missing free() calls.

Fixes: 9f9c9a8de2d5e96c ("perf tests: Add dlfilter test")
Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20210820113132.724034-1-rickyman7@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/dlfilter-test.c

index 7eba795..bc03b5d 100644 (file)
@@ -239,15 +239,20 @@ static int get_dlfilters_path(char *buf, size_t sz)
 
 static int check_filter_desc(struct test_data *td)
 {
-       char *long_desc;
-       char *desc;
+       char *long_desc = NULL;
+       char *desc = NULL;
+       int ret;
 
        if (get_filter_desc(td->dlfilters, "dlfilter-test-api-v0.so", &desc, &long_desc) &&
            long_desc && !strcmp(long_desc, "Filter used by the 'dlfilter C API' perf test") &&
            desc && !strcmp(desc, "dlfilter to test v0 C API"))
-               return 0;
+               ret = 0;
+       else
+               ret = -1;
 
-       return -1;
+       free(desc);
+       free(long_desc);
+       return ret;
 }
 
 static int get_ip_addr(struct test_data *td)