clk: socfpga: arria10: Fix memory leak of socfpga_clk on error return
authorColin Ian King <colin.king@canonical.com>
Tue, 6 Apr 2021 17:01:15 +0000 (18:01 +0100)
committerStephen Boyd <sboyd@kernel.org>
Wed, 7 Apr 2021 23:29:31 +0000 (16:29 -0700)
There is an error return path that is not kfree'ing socfpga_clk leading
to a memory leak. Fix this by adding in the missing kfree call.

Addresses-Coverity: ("Resource leak")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210406170115.430990-1-colin.king@canonical.com
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/socfpga/clk-gate-a10.c

index f5cba82..738c533 100644 (file)
@@ -146,6 +146,7 @@ static void __init __socfpga_gate_init(struct device_node *node,
                if (IS_ERR(socfpga_clk->sys_mgr_base_addr)) {
                        pr_err("%s: failed to find altr,sys-mgr regmap!\n",
                                        __func__);
+                       kfree(socfpga_clk);
                        return;
                }
        }