lib: stackdepot: fix ignoring return value warning
authorVijayanand Jitta <vjitta@codeaurora.org>
Fri, 26 Feb 2021 01:21:31 +0000 (17:21 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 26 Feb 2021 17:41:04 +0000 (09:41 -0800)
Fix the below ignoring return value warning for kstrtobool in
is_stack_depot_disabled function.

lib/stackdepot.c: In function 'is_stack_depot_disabled':
lib/stackdepot.c:154:2: warning: ignoring return value of 'kstrtobool'
declared with attribute 'warn_unused_result' [-Wunused-result]

Link: https://lkml.kernel.org/r/1612163048-28026-1-git-send-email-vjitta@codeaurora.org
Fixes: b9779abb09a8 ("lib: stackdepot: add support to disable stack depot")
Signed-off-by: Vijayanand Jitta <vjitta@codeaurora.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/stackdepot.c

index cc21116..49f67a0 100644 (file)
@@ -151,8 +151,10 @@ static struct stack_record **stack_table;
 
 static int __init is_stack_depot_disabled(char *str)
 {
-       kstrtobool(str, &stack_depot_disable);
-       if (stack_depot_disable) {
+       int ret;
+
+       ret = kstrtobool(str, &stack_depot_disable);
+       if (!ret && stack_depot_disable) {
                pr_info("Stack Depot is disabled\n");
                stack_table = NULL;
        }