cpufreq: s5pv210: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 16:00:15 +0000 (18:00 +0200)
committerViresh Kumar <viresh.kumar@linaro.org>
Wed, 16 Sep 2020 08:42:18 +0000 (14:12 +0530)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/s5pv210-cpufreq.c

index e84281e..7dccdb3 100644 (file)
@@ -590,6 +590,7 @@ static struct notifier_block s5pv210_cpufreq_reboot_notifier = {
 
 static int s5pv210_cpufreq_probe(struct platform_device *pdev)
 {
+       struct device *dev = &pdev->dev;
        struct device_node *np;
        int id, result = 0;
 
@@ -602,21 +603,14 @@ static int s5pv210_cpufreq_probe(struct platform_device *pdev)
         * cpufreq-dt driver.
         */
        arm_regulator = regulator_get(NULL, "vddarm");
-       if (IS_ERR(arm_regulator)) {
-               if (PTR_ERR(arm_regulator) == -EPROBE_DEFER)
-                       pr_debug("vddarm regulator not ready, defer\n");
-               else
-                       pr_err("failed to get regulator vddarm\n");
-               return PTR_ERR(arm_regulator);
-       }
+       if (IS_ERR(arm_regulator))
+               return dev_err_probe(dev, PTR_ERR(arm_regulator),
+                                    "failed to get regulator vddarm\n");
 
        int_regulator = regulator_get(NULL, "vddint");
        if (IS_ERR(int_regulator)) {
-               if (PTR_ERR(int_regulator) == -EPROBE_DEFER)
-                       pr_debug("vddint regulator not ready, defer\n");
-               else
-                       pr_err("failed to get regulator vddint\n");
-               result = PTR_ERR(int_regulator);
+               result = dev_err_probe(dev, PTR_ERR(int_regulator),
+                                      "failed to get regulator vddint\n");
                goto err_int_regulator;
        }