net: hns3: remove redundant param to simplify code
authorPeng Li <lipeng321@huawei.com>
Fri, 27 Aug 2021 09:28:21 +0000 (17:28 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Aug 2021 10:20:21 +0000 (11:20 +0100)
The param msg_q is redundant, copy &req->msg to
hdev->arq.msg_q[hdev->arq.tail] directly makes code clean.
So removes the redundant param msg_q.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c

index d42e271..46d06e1 100644 (file)
@@ -161,7 +161,6 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev)
        struct hclge_mbx_pf_to_vf_cmd *req;
        struct hclgevf_cmq_ring *crq;
        struct hclgevf_desc *desc;
-       u16 *msg_q;
        u16 flag;
 
        resp = &hdev->mbx_resp;
@@ -243,8 +242,7 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev)
                        }
 
                        /* tail the async message in arq */
-                       msg_q = hdev->arq.msg_q[hdev->arq.tail];
-                       memcpy(&msg_q[0], &req->msg,
+                       memcpy(hdev->arq.msg_q[hdev->arq.tail], &req->msg,
                               HCLGE_MBX_MAX_ARQ_MSG_SIZE * sizeof(u16));
                        hclge_mbx_tail_ptr_move_arq(hdev->arq);
                        atomic_inc(&hdev->arq.count);