fuse: update attr_version counter on fuse_notify_inval_inode()
authorMiklos Szeredi <mszeredi@redhat.com>
Tue, 19 May 2020 12:50:38 +0000 (14:50 +0200)
committerMiklos Szeredi <mszeredi@redhat.com>
Tue, 19 May 2020 12:50:38 +0000 (14:50 +0200)
A GETATTR request can race with FUSE_NOTIFY_INVAL_INODE, resulting in the
attribute cache being updated with stale information after the
invalidation.

Fix this by bumping the attribute version in fuse_reverse_inval_inode().

Reported-by: Krzysztof Rusek <rusek@9livesdata.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/fuse/inode.c

index 6fae66c..5b4aebf 100644 (file)
@@ -321,6 +321,8 @@ struct inode *fuse_iget(struct super_block *sb, u64 nodeid,
 int fuse_reverse_inval_inode(struct super_block *sb, u64 nodeid,
                             loff_t offset, loff_t len)
 {
+       struct fuse_conn *fc = get_fuse_conn_super(sb);
+       struct fuse_inode *fi;
        struct inode *inode;
        pgoff_t pg_start;
        pgoff_t pg_end;
@@ -329,6 +331,11 @@ int fuse_reverse_inval_inode(struct super_block *sb, u64 nodeid,
        if (!inode)
                return -ENOENT;
 
+       fi = get_fuse_inode(inode);
+       spin_lock(&fi->lock);
+       fi->attr_version = atomic64_inc_return(&fc->attr_version);
+       spin_unlock(&fi->lock);
+
        fuse_invalidate_attr(inode);
        forget_all_cached_acls(inode);
        if (offset >= 0) {