iwlwifi: dbg-tlv: fix old length in is_trig_data_contained()
authorJohannes Berg <johannes.berg@intel.com>
Wed, 9 Dec 2020 21:16:37 +0000 (23:16 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Wed, 9 Dec 2020 22:14:21 +0000 (00:14 +0200)
There's a bug in the lengths - the 'old length' needs to be calculated
using the 'old' pointer, of course, likely a copy/paste mistake. Fix
this.

Reported-by: Daniel Gabay <daniel.gabay@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Fixes: cf29c5b66b9f ("iwlwifi: dbg_ini: implement time point handling")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20201209231352.c0105ddffa74.I1ddb243053ff763c91b663748b6a593ecc3b5634@changeid
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c

index 51ce93d..8fa1c22 100644 (file)
@@ -808,7 +808,7 @@ static bool is_trig_data_contained(struct iwl_ucode_tlv *new,
        struct iwl_fw_ini_trigger_tlv *old_trig = (void *)old->data;
        __le32 *new_data = new_trig->data, *old_data = old_trig->data;
        u32 new_dwords_num = iwl_tlv_array_len(new, new_trig, data);
-       u32 old_dwords_num = iwl_tlv_array_len(new, new_trig, data);
+       u32 old_dwords_num = iwl_tlv_array_len(old, old_trig, data);
        int i, j;
 
        for (i = 0; i < new_dwords_num; i++) {