ice: remove redundant continue statement in a for-loop
authorColin Ian King <colin.king@canonical.com>
Tue, 15 Jun 2021 14:28:47 +0000 (15:28 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 17 Jun 2021 16:25:06 +0000 (09:25 -0700)
The continue statement in the for-loop is redundant. Re-work the hw_lock
check to remove it.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_ptp_hw.c

index 267312f..3eca0e4 100644 (file)
@@ -410,13 +410,11 @@ bool ice_ptp_lock(struct ice_hw *hw)
        for (i = 0; i < MAX_TRIES; i++) {
                hw_lock = rd32(hw, PFTSYN_SEM + (PFTSYN_SEM_BYTES * hw->pf_id));
                hw_lock = hw_lock & PFTSYN_SEM_BUSY_M;
-               if (hw_lock) {
-                       /* Somebody is holding the lock */
-                       usleep_range(10000, 20000);
-                       continue;
-               } else {
+               if (!hw_lock)
                        break;
-               }
+
+               /* Somebody is holding the lock */
+               usleep_range(10000, 20000);
        }
 
        return !hw_lock;