media: staging: rkisp1: rsz: make const array static, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Tue, 20 Oct 2020 14:46:55 +0000 (16:46 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:10 +0000 (10:31 +0100)
Don't populate the const array dev_names on the stack but instead it
static. Makes the object code smaller by 15 bytes.

Before:
   text    data     bss     dec     hex filename
  17091    2648      64   19803    4d5b media/rkisp1/rkisp1-resizer.o

After:
   text    data     bss     dec     hex filename
  17012    2712      64   19788    4d4c media/rkisp1/rkisp1-resizer.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/rkisp1/rkisp1-resizer.c

index 1687d82..7ca5b47 100644 (file)
@@ -763,8 +763,10 @@ static void rkisp1_rsz_unregister(struct rkisp1_resizer *rsz)
 
 static int rkisp1_rsz_register(struct rkisp1_resizer *rsz)
 {
-       const char * const dev_names[] = {RKISP1_RSZ_MP_DEV_NAME,
-                                         RKISP1_RSZ_SP_DEV_NAME};
+       static const char * const dev_names[] = {
+               RKISP1_RSZ_MP_DEV_NAME,
+               RKISP1_RSZ_SP_DEV_NAME
+       };
        struct media_pad *pads = rsz->pads;
        struct v4l2_subdev *sd = &rsz->sd;
        int ret;