qlcnic: Use list_for_each_entry() to simplify code in qlcnic_main.c
authorWang Hai <wanghai38@huawei.com>
Wed, 16 Jun 2021 04:21:06 +0000 (12:21 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Jun 2021 07:44:54 +0000 (00:44 -0700)
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c

index 96b947f..8a31ce2 100644 (file)
@@ -319,10 +319,8 @@ int qlcnic_read_mac_addr(struct qlcnic_adapter *adapter)
 static void qlcnic_delete_adapter_mac(struct qlcnic_adapter *adapter)
 {
        struct qlcnic_mac_vlan_list *cur;
-       struct list_head *head;
 
-       list_for_each(head, &adapter->mac_list) {
-               cur = list_entry(head, struct qlcnic_mac_vlan_list, list);
+       list_for_each_entry(cur, &adapter->mac_list, list) {
                if (ether_addr_equal_unaligned(adapter->mac_addr, cur->mac_addr)) {
                        qlcnic_sre_macaddr_change(adapter, cur->mac_addr,
                                                  0, QLCNIC_MAC_DEL);