net: dsa: qca8k: fix noderef.cocci warnings
authorkernel test robot <lkp@intel.com>
Wed, 9 Feb 2022 22:13:04 +0000 (06:13 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 10 Feb 2022 18:56:00 +0000 (10:56 -0800)
drivers/net/dsa/qca8k.c:422:37-43: ERROR: application of sizeof to pointer

 sizeof when applied to a pointer typed expression gives the size of
 the pointer

Generated by: scripts/coccinelle/misc/noderef.cocci

Fixes: 90386223f44e ("net: dsa: qca8k: add support for larger read/write size with mgmt Ethernet")
CC: Ansuel Smith <ansuelsmth@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20220209221304.GA17529@d2214a582157
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/qca8k.c

index bb2fbb6..c09d156 100644 (file)
@@ -456,7 +456,7 @@ qca8k_regmap_read(void *ctx, uint32_t reg, uint32_t *val)
        u16 r1, r2, page;
        int ret;
 
-       if (!qca8k_read_eth(priv, reg, val, sizeof(val)))
+       if (!qca8k_read_eth(priv, reg, val, sizeof(*val)))
                return 0;
 
        qca8k_split_addr(reg, &r1, &r2, &page);