drm/komeda: Correct the sequence of hw_done() and flip_done()
authorJames Qian Wang <james.qian.wang@arm.com>
Thu, 19 Nov 2020 01:39:48 +0000 (09:39 +0800)
committerLiviu Dudau <liviu.dudau@arm.com>
Fri, 18 Dec 2020 16:35:41 +0000 (16:35 +0000)
Komeda HW has no special, program the update to HW is done first,
then flip happens. So correct the sequence to hw_done() first then
flip_done().

Reported-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: James Qian Wang <james.qian.wang@arm.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20201119013948.2866343-1-james.qian.wang@arm.com
drivers/gpu/drm/arm/display/komeda/komeda_kms.c

index 6b99df6..034ee08 100644 (file)
@@ -81,10 +81,10 @@ static void komeda_kms_commit_tail(struct drm_atomic_state *old_state)
 
        drm_atomic_helper_commit_modeset_enables(dev, old_state);
 
-       drm_atomic_helper_wait_for_flip_done(dev, old_state);
-
        drm_atomic_helper_commit_hw_done(old_state);
 
+       drm_atomic_helper_wait_for_flip_done(dev, old_state);
+
        drm_atomic_helper_cleanup_planes(dev, old_state);
 }