media: atomisp: spctrl: be sure to zero .code_addr after free
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 12 May 2020 10:45:40 +0000 (12:45 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 20 May 2020 12:51:28 +0000 (14:51 +0200)
We need that to avoid trying to double-free the driver.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c

index ceaac82..db39fa2 100644 (file)
@@ -123,8 +123,10 @@ enum ia_css_err ia_css_spctrl_unload_fw(sp_ID_t sp_id)
                return IA_CSS_ERR_INVALID_ARGUMENTS;
 
        /*  freeup the resource */
-       if (spctrl_cofig_info[sp_id].code_addr)
+       if (spctrl_cofig_info[sp_id].code_addr) {
                hmm_free(spctrl_cofig_info[sp_id].code_addr);
+               spctrl_cofig_info[sp_id].code_addr = mmgr_NULL;
+       }
        spctrl_loaded[sp_id] = false;
        return IA_CSS_SUCCESS;
 }