ALSA: fireface: fix return value in error path of isochronous resources reservation
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Mon, 9 Dec 2019 15:05:41 +0000 (00:05 +0900)
committerTakashi Iwai <tiwai@suse.de>
Mon, 9 Dec 2019 19:06:18 +0000 (20:06 +0100)
Even if isochronous resources reservation fails, error code doesn't return
in pcm.hw_params callback.

Cc: <stable@vger.kernel.org> #5.3+
Fixes: 55162d2bb0e8 ("ALSA: fireface: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20191209151655.GA8090@workstation
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/fireface/ff-pcm.c

index 4e3bd9a..bd91c6e 100644 (file)
@@ -247,7 +247,7 @@ static int pcm_hw_params(struct snd_pcm_substream *substream,
                mutex_unlock(&ff->mutex);
        }
 
-       return 0;
+       return err;
 }
 
 static int pcm_hw_free(struct snd_pcm_substream *substream)