staging/rdma/hfi1: diag.c change null comparisons

Use !foo rather than (foo == NULL) as recommended by checkpatch --strict

Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/rdma/hfi1/diag.c
index a9dc5e9..f687ddf 100644 (file)
--- a/drivers/staging/rdma/hfi1/diag.c
+++ b/drivers/staging/rdma/hfi1/diag.c
@@ -571,7 +571,7 @@ static ssize_t diagpkt_write(struct file *fp, const char __user *data,
        */
        if (dp.pbc) {
                dd = hfi1_lookup(dp.unit);
-               if (dd == NULL)
+               if (!dd)
                        return -ENODEV;
                vl = (dp.pbc >> PBC_VL_SHIFT) & PBC_VL_MASK;
                sc = dd->vld[vl].sc;
@@ -657,7 +657,7 @@ static int hfi1_snoop_open(struct inode *in, struct file *fp)
        mutex_lock(&hfi1_mutex);
 
        dd = hfi1_dd_from_sc_inode(in);
-       if (dd == NULL) {
+       if (!dd) {
                ret = -ENODEV;
                goto bail;
        }
@@ -744,7 +744,7 @@ static int hfi1_snoop_release(struct inode *in, struct file *fp)
        int mode_flag;
 
        dd = hfi1_dd_from_sc_inode(in);
-       if (dd == NULL)
+       if (!dd)
                return -ENODEV;
 
        spin_lock_irqsave(&dd->hfi1_snoop.snoop_lock, flags);
@@ -799,7 +799,7 @@ static unsigned int hfi1_snoop_poll(struct file *fp,
        struct hfi1_devdata *dd;
 
        dd = hfi1_dd_from_sc_inode(fp->f_inode);
-       if (dd == NULL)
+       if (!dd)
                return -ENODEV;
 
        spin_lock_irqsave(&dd->hfi1_snoop.snoop_lock, flags);
@@ -826,7 +826,7 @@ static ssize_t hfi1_snoop_write(struct file *fp, const char __user *data,
        struct hfi1_pportdata *ppd;
 
        dd = hfi1_dd_from_sc_inode(fp->f_inode);
-       if (dd == NULL)
+       if (!dd)
                return -ENODEV;
 
        ppd = dd->pport;
@@ -924,7 +924,7 @@ static ssize_t hfi1_snoop_read(struct file *fp, char __user *data,
        struct hfi1_devdata *dd;
 
        dd = hfi1_dd_from_sc_inode(fp->f_inode);
-       if (dd == NULL)
+       if (!dd)
                return -ENODEV;
 
        spin_lock_irqsave(&dd->hfi1_snoop.snoop_lock, flags);
@@ -982,7 +982,7 @@ static long hfi1_ioctl(struct file *fp, unsigned int cmd, unsigned long arg)
        struct hfi1_link_info link_info;
 
        dd = hfi1_dd_from_sc_inode(fp->f_inode);
-       if (dd == NULL)
+       if (!dd)
                return -ENODEV;
 
        spin_lock_irqsave(&dd->hfi1_snoop.snoop_lock, flags);
@@ -1546,7 +1546,7 @@ int snoop_recv_handler(struct hfi1_packet *packet)
                                                 tlen - header_size,
                                                 md_len);
 
-               if (unlikely(s_packet == NULL)) {
+               if (unlikely(!s_packet)) {
                        dd_dev_warn_ratelimited(ppd->dd, "Unable to allocate snoop/capture packet\n");
                        break;
                }
@@ -1667,7 +1667,7 @@ int snoop_send_pio_handler(struct hfi1_qp *qp, struct hfi1_pkt_state *ps,
        /* not using ss->total_len as arg 2 b/c that does not count CRC */
        s_packet = allocate_snoop_packet(hdr_len, tlen - hdr_len, md_len);
 
-       if (unlikely(s_packet == NULL)) {
+       if (unlikely(!s_packet)) {
                dd_dev_warn_ratelimited(ppd->dd, "Unable to allocate snoop/capture packet\n");
                goto out;
        }
@@ -1836,7 +1836,7 @@ void snoop_inline_pio_send(struct hfi1_devdata *dd, struct pio_buf *pbuf,
 
                s_packet = allocate_snoop_packet(packet_len, 0, md_len);
 
-               if (unlikely(s_packet == NULL)) {
+               if (unlikely(!s_packet)) {
                        dd_dev_warn_ratelimited(dd, "Unable to allocate snoop/capture packet\n");
                        goto inline_pio_out;
                }