net/sched: act_ct: Fix adding udp port mangle operation
authorRoi Dayan <roid@nvidia.com>
Mon, 19 Oct 2020 09:02:44 +0000 (12:02 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 20 Oct 2020 23:15:51 +0000 (16:15 -0700)
Need to use the udp header type and not tcp.

Fixes: 9c26ba9b1f45 ("net/sched: act_ct: Instantiate flow table entry actions")
Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Paul Blakey <paulb@nvidia.com>
Link: https://lore.kernel.org/r/20201019090244.3015186-1-roid@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/act_ct.c

index 9c79fb9..aba3cd8 100644 (file)
@@ -156,11 +156,11 @@ tcf_ct_flow_table_add_action_nat_udp(const struct nf_conntrack_tuple *tuple,
        __be16 target_dst = target.dst.u.udp.port;
 
        if (target_src != tuple->src.u.udp.port)
-               tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_TCP,
+               tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_UDP,
                                         offsetof(struct udphdr, source),
                                         0xFFFF, be16_to_cpu(target_src));
        if (target_dst != tuple->dst.u.udp.port)
-               tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_TCP,
+               tcf_ct_add_mangle_action(action, FLOW_ACT_MANGLE_HDR_TYPE_UDP,
                                         offsetof(struct udphdr, dest),
                                         0xFFFF, be16_to_cpu(target_dst));
 }