net/mlx5e: fix error return code in mlx5e_alloc_rq()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 5 Jun 2018 02:42:56 +0000 (02:42 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 5 Jun 2018 14:20:33 +0000 (10:20 -0400)
Fix to return error code -ENOMEM from the kvzalloc_node() error handling
case instead of 0, as done elsewhere in this function.

Fixes: 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue memory scheme")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c

index 333d4ed..89c96a0 100644 (file)
@@ -566,8 +566,10 @@ static int mlx5e_alloc_rq(struct mlx5e_channel *c,
                        kvzalloc_node((wq_sz << rq->wqe.info.log_num_frags) *
                                      sizeof(*rq->wqe.frags),
                                      GFP_KERNEL, cpu_to_node(c->cpu));
-               if (!rq->wqe.frags)
+               if (!rq->wqe.frags) {
+                       err = -ENOMEM;
                        goto err_free;
+               }
 
                err = mlx5e_init_di_list(rq, params, wq_sz, c->cpu);
                if (err)