drm/exynos: use pm_runtime_resume_and_get()

Use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()
to deal with usage counter. pm_runtime_get_sync() increases the
usage counter even when it failed, which makes callers to forget
to decrease the usage counter and resulted in reference leak.

pm_runtime_resume_and_get() function decreases the usage counter
when it failed internally so it can avoid the reference leak.

Changelog v1:
- Fix an build error reported by kernel test robot of Intel.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
Reported-by: kernel test robot <lkp@intel.com>

diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
index 197b973..9870c4e 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c
@@ -513,8 +513,13 @@ static void decon_swreset(struct decon_context *ctx)
 static void decon_atomic_enable(struct exynos_drm_crtc *crtc)
 {
        struct decon_context *ctx = crtc->ctx;
+       int ret;
 
-       pm_runtime_get_sync(ctx->dev);
+       ret = pm_runtime_resume_and_get(ctx->dev);
+       if (ret < 0) {
+               DRM_DEV_ERROR(ctx->dev, "failed to enable DECON device.\n");
+               return;
+       }
 
        exynos_drm_pipe_clk_enable(crtc, true);
 

diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
index 9b5e6f9..12571ac 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
+++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
@@ -531,11 +531,16 @@ static void decon_init(struct decon_context *ctx)
 static void decon_atomic_enable(struct exynos_drm_crtc *crtc)
 {
        struct decon_context *ctx = crtc->ctx;
+       int ret;
 
        if (!ctx->suspended)
                return;
 
-       pm_runtime_get_sync(ctx->dev);
+       ret = pm_runtime_resume_and_get(ctx->dev);
+       if (ret < 0) {
+               DRM_DEV_ERROR(ctx->dev, "failed to enable DECON device.\n");
+               return;
+       }
 
        decon_init(ctx);
 

diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 2d2fe5a..1d777d8 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1383,7 +1383,12 @@ static void exynos_dsi_enable(struct drm_encoder *encoder)
        if (dsi->state & DSIM_STATE_ENABLED)
                return;
 
-       pm_runtime_get_sync(dsi->dev);
+       ret = pm_runtime_resume_and_get(dsi->dev);
+       if (ret < 0) {
+               dev_err(dsi->dev, "failed to enable DSI device.\n");
+               return;
+       }
+
        dsi->state |= DSIM_STATE_ENABLED;
 
        if (dsi->panel) {

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
index 29ab8be..a3c7181 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c
@@ -1085,8 +1085,14 @@ static int fimc_commit(struct exynos_drm_ipp *ipp,
 {
        struct fimc_context *ctx =
                        container_of(ipp, struct fimc_context, ipp);
+       int ret;
+
+       ret = pm_runtime_resume_and_get(ctx->dev);
+       if (ret < 0) {
+               dev_err(ctx->dev, "failed to enable FIMC device.\n");
+               return ret;
+       }
 
-       pm_runtime_get_sync(ctx->dev);
        ctx->task = task;
 
        fimc_src_set_fmt(ctx, task->src.buf.fourcc, task->src.buf.modifier);

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index ae57612..700ca4f 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -343,13 +343,18 @@ static void fimd_enable_shadow_channel_path(struct fimd_context *ctx,
        writel(val, ctx->regs + SHADOWCON);
 }
 
-static void fimd_clear_channels(struct exynos_drm_crtc *crtc)
+static int fimd_clear_channels(struct exynos_drm_crtc *crtc)
 {
        struct fimd_context *ctx = crtc->ctx;
        unsigned int win, ch_enabled = 0;
+       int ret;
 
        /* Hardware is in unknown state, so ensure it gets enabled properly */
-       pm_runtime_get_sync(ctx->dev);
+       ret = pm_runtime_resume_and_get(ctx->dev);
+       if (ret < 0) {
+               dev_err(ctx->dev, "failed to enable FIMD device.\n");
+               return ret;
+       }
 
        clk_prepare_enable(ctx->bus_clk);
        clk_prepare_enable(ctx->lcd_clk);
@@ -384,6 +389,8 @@ static void fimd_clear_channels(struct exynos_drm_crtc *crtc)
        clk_disable_unprepare(ctx->bus_clk);
 
        pm_runtime_put(ctx->dev);
+
+       return 0;
 }
 
 
@@ -905,7 +912,10 @@ static void fimd_atomic_enable(struct exynos_drm_crtc *crtc)
 
        ctx->suspended = false;
 
-       pm_runtime_get_sync(ctx->dev);
+       if (pm_runtime_resume_and_get(ctx->dev) < 0) {
+               dev_warn(ctx->dev, "failed to enable FIMD device.\n");
+               return;
+       }
 
        /* if vblank was enabled status, enable it again. */
        if (test_and_clear_bit(0, &ctx->irq_flags))
@@ -1089,8 +1099,13 @@ static int fimd_bind(struct device *dev, struct device *master, void *data)
        if (ctx->encoder)
                exynos_dpi_bind(drm_dev, ctx->encoder);
 
-       if (is_drm_iommu_supported(drm_dev))
-               fimd_clear_channels(ctx->crtc);
+       if (is_drm_iommu_supported(drm_dev)) {
+               int ret;
+
+               ret = fimd_clear_channels(ctx->crtc);
+               if (ret < 0)
+                       return ret;
+       }
 
        return exynos_drm_register_dma(drm_dev, dev, &ctx->dma_priv);
 }

diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index 1e0c5a7..cab4d2c 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -892,7 +892,14 @@ static void g2d_runqueue_worker(struct work_struct *work)
                g2d->runqueue_node = g2d_get_runqueue_node(g2d);
 
                if (g2d->runqueue_node) {
-                       pm_runtime_get_sync(g2d->dev);
+                       int ret;
+
+                       ret = pm_runtime_resume_and_get(g2d->dev);
+                       if (ret < 0) {
+                               dev_err(g2d->dev, "failed to enable G2D device.\n");
+                               return;
+                       }
+
                        g2d_dma_start(g2d, g2d->runqueue_node);
                }
        }

diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
index b01f36e..90d7bf9 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
@@ -1118,7 +1118,12 @@ static int gsc_commit(struct exynos_drm_ipp *ipp,
        struct gsc_context *ctx = container_of(ipp, struct gsc_context, ipp);
        int ret;
 
-       pm_runtime_get_sync(ctx->dev);
+       ret = pm_runtime_resume_and_get(ctx->dev);
+       if (ret < 0) {
+               dev_err(ctx->dev, "failed to enable GScaler device.\n");
+               return ret;
+       }
+
        ctx->task = task;
 
        ret = gsc_reset(ctx);

diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c b/drivers/gpu/drm/exynos/exynos_drm_rotator.c
index 2d94afb..ee61be4 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c
@@ -219,8 +219,13 @@ static int rotator_commit(struct exynos_drm_ipp *ipp,
 {
        struct rot_context *rot =
                        container_of(ipp, struct rot_context, ipp);
+       int ret;
 
-       pm_runtime_get_sync(rot->dev);
+       ret = pm_runtime_resume_and_get(rot->dev);
+       if (ret < 0) {
+               dev_err(rot->dev, "failed to enable ROTATOR device.\n");
+               return ret;
+       }
        rot->task = task;
 
        rotator_src_set_fmt(rot, task->src.buf.fourcc);

diff --git a/drivers/gpu/drm/exynos/exynos_drm_scaler.c b/drivers/gpu/drm/exynos/exynos_drm_scaler.c
index ce18571..f9ae5b0 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_drm_scaler.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_scaler.c
@@ -362,15 +362,17 @@ static int scaler_commit(struct exynos_drm_ipp *ipp,
        struct drm_exynos_ipp_task_rect *src_pos = &task->src.rect;
        struct drm_exynos_ipp_task_rect *dst_pos = &task->dst.rect;
        const struct scaler_format *src_fmt, *dst_fmt;
+       int ret = 0;
 
        src_fmt = scaler_get_format(task->src.buf.fourcc);
        dst_fmt = scaler_get_format(task->dst.buf.fourcc);
 
-       pm_runtime_get_sync(scaler->dev);
-       if (scaler_reset(scaler)) {
-               pm_runtime_put(scaler->dev);
+       ret = pm_runtime_resume_and_get(scaler->dev);
+       if (ret < 0)
+               return ret;
+
+       if (scaler_reset(scaler))
                return -EIO;
-       }
 
        scaler->task = task;
 

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 39fa5d3..f893731 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -1483,10 +1483,16 @@ static void hdmi_set_refclk(struct hdmi_context *hdata, bool on)
 /* Should be called with hdata->mutex mutex held. */
 static void hdmiphy_enable(struct hdmi_context *hdata)
 {
+       int ret;
+
        if (hdata->powered)
                return;
 
-       pm_runtime_get_sync(hdata->dev);
+       ret = pm_runtime_resume_and_get(hdata->dev);
+       if (ret < 0) {
+               dev_err(hdata->dev, "failed to enable HDMIPHY device.\n");
+               return;
+       }
 
        if (regulator_bulk_enable(ARRAY_SIZE(supply), hdata->regul_bulk))
                DRM_DEV_DEBUG_KMS(hdata->dev,

diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
index af192e5..41c54f1 100644 (file)
--- a/drivers/gpu/drm/exynos/exynos_mixer.c
+++ b/drivers/gpu/drm/exynos/exynos_mixer.c
@@ -992,11 +992,16 @@ static void mixer_atomic_flush(struct exynos_drm_crtc *crtc)
 static void mixer_atomic_enable(struct exynos_drm_crtc *crtc)
 {
        struct mixer_context *ctx = crtc->ctx;
+       int ret;
 
        if (test_bit(MXR_BIT_POWERED, &ctx->flags))
                return;
 
-       pm_runtime_get_sync(ctx->dev);
+       ret = pm_runtime_resume_and_get(ctx->dev);
+       if (ret < 0) {
+               dev_err(ctx->dev, "failed to enable MIXER device.\n");
+               return;
+       }
 
        exynos_drm_pipe_clk_enable(crtc, true);