dm zoned: Avoid 64-bit division error in dmz_fixup_devices
authorNathan Chancellor <natechancellor@gmail.com>
Wed, 13 May 2020 08:45:22 +0000 (01:45 -0700)
committerMike Snitzer <snitzer@redhat.com>
Wed, 20 May 2020 21:09:48 +0000 (17:09 -0400)
When building arm32 allyesconfig:

ld.lld: error: undefined symbol: __aeabi_uldivmod
>>> referenced by dm-zoned-target.c
>>>               md/dm-zoned-target.o:(dmz_ctr) in archive drivers/built-in.a

dmz_fixup_devices uses DIV_ROUND_UP with variables of type sector_t. As
such, it should be using DIV_ROUND_UP_SECTOR_T, which handles this
automatically.

Fixes: 70978208ec91 ("dm zoned: metadata version 2")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-zoned-target.c

index a3d572d..b586fc6 100644 (file)
@@ -803,8 +803,9 @@ static int dmz_fixup_devices(struct dm_target *ti)
 
        if (reg_dev) {
                reg_dev->zone_nr_sectors = zoned_dev->zone_nr_sectors;
-               reg_dev->nr_zones = DIV_ROUND_UP(reg_dev->capacity,
-                                                reg_dev->zone_nr_sectors);
+               reg_dev->nr_zones =
+                       DIV_ROUND_UP_SECTOR_T(reg_dev->capacity,
+                                             reg_dev->zone_nr_sectors);
                zoned_dev->zone_offset = reg_dev->nr_zones;
        }
        return 0;