netdevsim: Create a helper for setting nexthop hardware flags
authorIdo Schimmel <idosch@nvidia.com>
Fri, 12 Mar 2021 16:50:18 +0000 (17:50 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 13 Mar 2021 01:44:10 +0000 (17:44 -0800)
Instead of calling nexthop_set_hw_flags(), call a helper. It will be
used to also set nexthop bucket flags in a subsequent patch.

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netdevsim/fib.c

index ba577e2..62cbd71 100644 (file)
@@ -1157,6 +1157,13 @@ err_num_decrease:
 
 }
 
+static void nsim_nexthop_hw_flags_set(struct net *net,
+                                     const struct nsim_nexthop *nexthop,
+                                     bool trap)
+{
+       nexthop_set_hw_flags(net, nexthop->id, false, trap);
+}
+
 static int nsim_nexthop_add(struct nsim_fib_data *data,
                            struct nsim_nexthop *nexthop,
                            struct netlink_ext_ack *extack)
@@ -1175,7 +1182,7 @@ static int nsim_nexthop_add(struct nsim_fib_data *data,
                goto err_nexthop_dismiss;
        }
 
-       nexthop_set_hw_flags(net, nexthop->id, false, true);
+       nsim_nexthop_hw_flags_set(net, nexthop, true);
 
        return 0;
 
@@ -1204,7 +1211,7 @@ static int nsim_nexthop_replace(struct nsim_fib_data *data,
                goto err_nexthop_dismiss;
        }
 
-       nexthop_set_hw_flags(net, nexthop->id, false, true);
+       nsim_nexthop_hw_flags_set(net, nexthop, true);
        nsim_nexthop_account(data, nexthop_old->occ, false, extack);
        nsim_nexthop_destroy(nexthop_old);
 
@@ -1286,7 +1293,7 @@ static void nsim_nexthop_free(void *ptr, void *arg)
        struct net *net;
 
        net = devlink_net(data->devlink);
-       nexthop_set_hw_flags(net, nexthop->id, false, false);
+       nsim_nexthop_hw_flags_set(net, nexthop, false);
        nsim_nexthop_account(data, nexthop->occ, false, NULL);
        nsim_nexthop_destroy(nexthop);
 }