scsi: mpt3sas: Fix incorrectly assigned error return and check
authorColin Ian King <colin.king@canonical.com>
Wed, 4 Aug 2021 13:49:40 +0000 (14:49 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 10 Aug 2021 03:46:19 +0000 (23:46 -0400)
Currently the call to _base_static_config_pages() is assigning the error
return to variable 'rc' but checking the error return in error 'r'. Fix
this by assigning the error return to variable 'r' instead of 'rc'.

Link: https://lore.kernel.org/r/20210804134940.114011-1-colin.king@canonical.com
Fixes: 19a622c39a9d ("scsi: mpt3sas: Handle firmware faults during first half of IOC init")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Addresses-Coverity: ("Unused value")

drivers/scsi/mpt3sas/mpt3sas_base.c

index 19b1c0c..cf4a3a2 100644 (file)
@@ -7851,7 +7851,7 @@ _base_make_ioc_operational(struct MPT3SAS_ADAPTER *ioc)
                        return r;
        }
 
-       rc = _base_static_config_pages(ioc);
+       r = _base_static_config_pages(ioc);
        if (r)
                return r;