ALSA: hda/realtek: Fix pop noise on ALC225
authorKai-Heng Feng <kai.heng.feng@canonical.com>
Wed, 11 Mar 2020 06:13:28 +0000 (14:13 +0800)
committerTakashi Iwai <tiwai@suse.de>
Wed, 11 Mar 2020 06:54:27 +0000 (07:54 +0100)
Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to
0") makes the ALC225 have pop noise on S3 resume and cold boot.

So partially revert this commit for ALC225 to fix the regression.

Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0")
BugLink: https://bugs.launchpad.net/bugs/1866357
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Link: https://lore.kernel.org/r/20200311061328.17614-1-kai.heng.feng@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/patch_realtek.c

index 0ac06ff..7b83b02 100644 (file)
@@ -8051,6 +8051,8 @@ static int patch_alc269(struct hda_codec *codec)
                spec->gen.mixer_nid = 0;
                break;
        case 0x10ec0225:
+               codec->power_save_node = 1;
+               /* fall through */
        case 0x10ec0295:
        case 0x10ec0299:
                spec->codec_variant = ALC269_TYPE_ALC225;