net: x25: Use list_for_each_entry() to simplify code in x25_link.c
authorWang Hai <wanghai38@huawei.com>
Tue, 8 Jun 2021 08:05:05 +0000 (08:05 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 8 Jun 2021 23:31:24 +0000 (16:31 -0700)
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/x25/x25_link.c

index 57a8110..5460b91 100644 (file)
@@ -332,12 +332,9 @@ void x25_link_device_down(struct net_device *dev)
 struct x25_neigh *x25_get_neigh(struct net_device *dev)
 {
        struct x25_neigh *nb, *use = NULL;
-       struct list_head *entry;
 
        read_lock_bh(&x25_neigh_list_lock);
-       list_for_each(entry, &x25_neigh_list) {
-               nb = list_entry(entry, struct x25_neigh, node);
-
+       list_for_each_entry(nb, &x25_neigh_list, node) {
                if (nb->dev == dev) {
                        use = nb;
                        break;