ALSA: bebob: Fix bit flag quirk constants
authorColin Ian King <colin.king@canonical.com>
Tue, 15 Jun 2021 14:20:48 +0000 (15:20 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 16 Jun 2021 06:53:24 +0000 (08:53 +0200)
The quirking bit-flags are currently set as contiguous integer enum values
and so currently SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC is zero and so
he quirking never getting set or tested correctly for this quirk. Fix this
by setting the quirking constants as shifted bit values.

Addresses-Coverity: ("Bitwise-and with zero")
Fixes: 93cd12d6e88a ("ALSA: bebob: code refactoring for model-dependent quirks")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210615142048.59900-1-colin.king@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/bebob/bebob.h

index c06579d..4d73ecb 100644 (file)
@@ -76,8 +76,8 @@ struct snd_bebob_spec {
 };
 
 enum snd_bebob_quirk {
-       SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC,
-       SND_BEBOB_QUIRK_WRONG_DBC,
+       SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC = (1 << 0),
+       SND_BEBOB_QUIRK_WRONG_DBC                 = (1 << 1),
 };
 
 struct snd_bebob {