ksmbd: add missing assignments to ret on ndr_read_int64 read calls

Currently there are two ndr_read_int64 calls where ret is being checked
for failure but ret is not being assigned a return value from the call.
Static analyis is reporting the checks on ret as dead code.  Fix this.

Addresses-Coverity: ("Logical dead code")
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/ksmbd/ndr.c b/fs/ksmbd/ndr.c
index a476de2..8317f7c 100644 (file)
--- a/fs/ksmbd/ndr.c
+++ b/fs/ksmbd/ndr.c
@@ -275,11 +275,11 @@ int ndr_decode_dos_attr(struct ndr *n, struct xattr_dos_attrib *da)
                if (ret)
                        return ret;
 
-               ndr_read_int64(n, NULL);
+               ret = ndr_read_int64(n, NULL);
                if (ret)
                        return ret;
 
-               ndr_read_int64(n, NULL);
+               ret = ndr_read_int64(n, NULL);
                if (ret)
                        return ret;