mm/zsmalloc.c: improve readability for async_free_zspage()

The class is extracted from pool->size_class[class_idx] again before
calling __free_zspage().  It looks like class will change after we fetch
the class lock.  But this is misleading as class will stay unchanged.

Link: https://lkml.kernel.org/r/20210624123930.1769093-4-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 9198b16..68e8831 100644 (file)
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -2162,7 +2162,7 @@ static void async_free_zspage(struct work_struct *work)
                VM_BUG_ON(fullness != ZS_EMPTY);
                class = pool->size_class[class_idx];
                spin_lock(&class->lock);
-               __free_zspage(pool, pool->size_class[class_idx], zspage);
+               __free_zspage(pool, class, zspage);
                spin_unlock(&class->lock);
        }
 };