ath9k: Use tasklet_disable_in_atomic()
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tue, 9 Mar 2021 08:42:13 +0000 (09:42 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 17 Mar 2021 15:34:02 +0000 (16:34 +0100)
All callers of ath9k_beacon_ensure_primary_slot() are preemptible /
acquire a mutex except for this callchain:

  spin_lock_bh(&sc->sc_pcu_lock);
  ath_complete_reset()
  -> ath9k_calculate_summary_state()
     -> ath9k_beacon_ensure_primary_slot()

It's unclear how that can be distangled, so use tasklet_disable_in_atomic()
for now. This allows tasklet_disable() to become sleepable once the
remaining atomic users are cleaned up.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Kalle Valo <kvalo@codeaurora.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210309084242.313899703@linutronix.de
drivers/net/wireless/ath/ath9k/beacon.c

index 71e2ada..72e2e71 100644 (file)
@@ -251,7 +251,7 @@ void ath9k_beacon_ensure_primary_slot(struct ath_softc *sc)
        int first_slot = ATH_BCBUF;
        int slot;
 
-       tasklet_disable(&sc->bcon_tasklet);
+       tasklet_disable_in_atomic(&sc->bcon_tasklet);
 
        /* Find first taken slot. */
        for (slot = 0; slot < ATH_BCBUF; slot++) {