kselftest/arm64: mte: ksm_options: Fix fscanf warning
authorAndre Przywara <andre.przywara@arm.com>
Fri, 19 Mar 2021 16:53:26 +0000 (16:53 +0000)
committerCatalin Marinas <catalin.marinas@arm.com>
Tue, 23 Mar 2021 16:36:30 +0000 (16:36 +0000)
Out of the box Ubuntu's 20.04 compiler warns about missing return value
checks for fscanf() calls.

Make GCC happy by checking whether we actually parsed one integer.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Mark Brown <broone@kernel.org>
Link: https://lore.kernel.org/r/20210319165334.29213-4-andre.przywara@arm.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
tools/testing/selftests/arm64/mte/check_ksm_options.c

index 3b23c4d..88c74bc 100644 (file)
@@ -33,7 +33,10 @@ static unsigned long read_sysfs(char *str)
                ksft_print_msg("ERR: missing %s\n", str);
                return 0;
        }
-       fscanf(f, "%lu", &val);
+       if (fscanf(f, "%lu", &val) != 1) {
+               ksft_print_msg("ERR: parsing %s\n", str);
+               val = 0;
+       }
        fclose(f);
        return val;
 }