net: txgbe: Fix an error handling path in txgbe_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 31 Jul 2022 16:34:15 +0000 (18:34 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 1 Aug 2022 19:27:12 +0000 (12:27 -0700)
A pci_enable_pcie_error_reporting() should be balanced by a corresponding
pci_disable_pcie_error_reporting() call in the error handling path, as
already done in the remove function.

Fixes: 3ce7547e5b71 ("net: txgbe: Add build support for txgbe")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
Link: https://lore.kernel.org/r/082003d00be1f05578c9c6434272ceb314609b8e.1659285240.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/wangxun/txgbe/txgbe_main.c

index 55c3c72..d3b9f73 100644 (file)
@@ -123,6 +123,7 @@ static int txgbe_probe(struct pci_dev *pdev,
        return 0;
 
 err_pci_release_regions:
+       pci_disable_pcie_error_reporting(pdev);
        pci_release_selected_regions(pdev,
                                     pci_select_bars(pdev, IORESOURCE_MEM));
 err_pci_disable_dev: