EDAC/aspeed: Use proper format string for printing resource
authorArnd Bergmann <arnd@arndb.de>
Wed, 21 Apr 2021 13:54:53 +0000 (15:54 +0200)
committerBorislav Petkov <bp@suse.de>
Tue, 18 May 2021 14:33:13 +0000 (16:33 +0200)
On ARMv7, resource_size_t can be 64-bit, which breaks printing
it as %x:

  drivers/edac/aspeed_edac.c: In function 'init_csrows':
  drivers/edac/aspeed_edac.c:257:28: error: format '%x' expects argument of \
    type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long \
    long unsigned int'} [-Werror=format=]
  257 |         dev_dbg(mci->pdev, "dt: /memory node resources: first page \
    r.start=0x%x, resource_size=0x%x, PAGE_SHIFT macro=0x%x\n",

Use the special %pR format string to pretty-print the entire resource
instead.

Fixes: edfc2d73ca45 ("EDAC/aspeed: Add support for AST2400 and AST2600")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
Link: https://lkml.kernel.org/r/20210421135500.3518661-1-arnd@kernel.org
drivers/edac/aspeed_edac.c

index a46da56..6bd5f88 100644 (file)
@@ -254,8 +254,8 @@ static int init_csrows(struct mem_ctl_info *mci)
                return rc;
        }
 
-       dev_dbg(mci->pdev, "dt: /memory node resources: first page r.start=0x%x, resource_size=0x%x, PAGE_SHIFT macro=0x%x\n",
-               r.start, resource_size(&r), PAGE_SHIFT);
+       dev_dbg(mci->pdev, "dt: /memory node resources: first page %pR, PAGE_SHIFT macro=0x%x\n",
+               &r, PAGE_SHIFT);
 
        csrow->first_page = r.start >> PAGE_SHIFT;
        nr_pages = resource_size(&r) >> PAGE_SHIFT;