mmc: owl-mmc: Use dma_request_chan() instead dma_request_slave_channel()
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Tue, 17 Dec 2019 11:29:34 +0000 (13:29 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 19 Dec 2019 07:19:42 +0000 (08:19 +0100)
dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.

By using dma_request_chan() directly the driver can support deferred
probing against DMA.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20191217112934.31535-1-peter.ujfalusi@ti.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/owl-mmc.c

index 771e3d0..01ffe51 100644 (file)
@@ -616,10 +616,10 @@ static int owl_mmc_probe(struct platform_device *pdev)
 
        pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
        pdev->dev.dma_mask = &pdev->dev.coherent_dma_mask;
-       owl_host->dma = dma_request_slave_channel(&pdev->dev, "mmc");
-       if (!owl_host->dma) {
+       owl_host->dma = dma_request_chan(&pdev->dev, "mmc");
+       if (IS_ERR(owl_host->dma)) {
                dev_err(owl_host->dev, "Failed to get external DMA channel.\n");
-               ret = -ENXIO;
+               ret = PTR_ERR(owl_host->dma);
                goto err_free_host;
        }