usb: host: fhci-hcd: annotate PIPE_CONTROL switch case with fallthrough
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Thu, 13 Feb 2020 08:54:00 +0000 (09:54 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Feb 2020 10:08:52 +0000 (11:08 +0100)
After this was made buildable for something other than PPC32, kbuild
starts warning

drivers/usb/host/fhci-hcd.c:398:8: warning: this statement may fall
through [-Wimplicit-fallthrough=]

I don't know this code, but from the construction (initializing size
with 0 and explicitly using "size +=" in the PIPE_BULK case) I assume
that fallthrough is indeed intended.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: Li Yang <leoyang.li@nxp.com>
Link: https://lore.kernel.org/r/20200213085401.27862-1-linux@rasmusvillemoes.dk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/fhci-hcd.c

index 0473387..a8e1048 100644 (file)
@@ -396,6 +396,7 @@ static int fhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
        case PIPE_CONTROL:
                /* 1 td fro setup,1 for ack */
                size = 2;
+               fallthrough;
        case PIPE_BULK:
                /* one td for every 4096 bytes(can be up to 8k) */
                size += urb->transfer_buffer_length / 4096;